Add support for TimeProvider in DataProtectionTokenProvider and DataProtectionTokenProviderOptions#66586
Open
marcominerva wants to merge 2 commits into
Open
Add support for TimeProvider in DataProtectionTokenProvider and DataProtectionTokenProviderOptions#66586marcominerva wants to merge 2 commits into
marcominerva wants to merge 2 commits into
Conversation
…rotectionTokenProviderOptions
dotnet-policy-service
Bot
added
the
community-contribution
Contributor
|
Thanks for your PR, @marcominerva. Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
Contributor
There was a problem hiding this comment.
Pull request overview
Adds TimeProvider support to Identity's data-protection token provider so token generation/validation can use injectable time sources instead of DateTimeOffset.UtcNow, primarily to improve testability and align with existing Identity time abstractions.
Changes:
- Added
TimeProvidertoDataProtectionTokenProviderOptionsand exposed the resolved provider onDataProtectorTokenProvider<TUser>. - Updated token generation/validation to read current time from
TimeProvider. - Added DI post-configuration and new tests for option-based and DI-based time injection.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
src/Identity/test/Identity.Test/DataProtectorTokenProviderTest.cs |
Adds unit tests for token generation/validation and TimeProvider injection behavior. |
src/Identity/Core/src/PublicAPI.Unshipped.txt |
Records the new public API surface for TimeProvider. |
src/Identity/Core/src/IdentityServiceCollectionExtensions.cs |
Registers post-configuration for DataProtectionTokenProviderOptions in the AddIdentity path. |
src/Identity/Core/src/IdentityBuilderExtensions.cs |
Registers post-configuration for DataProtectionTokenProviderOptions in the default token-provider path. |
src/Identity/Core/src/DataProtectorTokenProvider.cs |
Switches token timestamp generation/validation to use TimeProvider. |
src/Identity/Core/src/DataProtectionTokenProviderOptions.cs |
Adds the new nullable TimeProvider option. |
…ions and add unit test for DI injection
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request enhances the
DataProtectorTokenProviderin ASP.NET Core Identity by introducing support forTimeProvider, enabling improved testability and flexibility for time-dependent operations like token generation and validation. It also ensures that theTimeProvidercan be injected via dependency injection (DI) or set directly in options, and adds a comprehensive suite of tests to verify these behaviors. This changes uses the same pattern already applied in theSecurityStampValidatorclass.Key changes:
TimeProvider support and integration
TimeProviderproperty toDataProtectionTokenProviderOptionsto allow overriding the system clock, primarily for testing scenarios.DataProtectorTokenProviderto use the configuredTimeProvider(falling back toTimeProvider.Systemif not set) for all time-based operations, replacing direct usage ofDateTimeOffset.UtcNow. [1] [2] [3] [4]PostConfigureDataProtectionTokenProviderOptionsclass to set theTimeProviderfrom DI if not already set, mirroring the pattern used forSecurityStampValidatorOptions. This ensures consistent configuration via DI. [1] [2] [3] [4]Testing improvements
DataProtectorTokenProviderTest.cswith comprehensive tests covering token generation/validation, token expiry based on customTimeProvider, and correct precedence between DI-injected and manually setTimeProvider.Public API updates
TimeProviderproperties and accessors for bothDataProtectionTokenProviderOptionsandDataProtectorTokenProvider<TUser>.Fixes #54639